Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlarge color difference between options in Confirm Alert #42

Merged
merged 2 commits into from Jun 1, 2022

Conversation

fscholdei
Copy link
Member

Proposed changes

Enlarge color difference between options in Confirm Alert

Your checklist for this pull request

Contributor:

  • PR is well described and the description can be used as a commit message on squash
  • Related issues linked to PR if existing and labels set
  • New code is covered with unit tests
  • New/updated ui components are tested inside the storybook (module ui-components only)
  • Changelog entry file created in gradle/changelog
  • Feature has been tested with different permissions
  • Documentation updated (only necessary for new features or changed behaviour)

Reviewer:

  • The clean code principles are respected (CleanCode)
  • All new code/logic is implemented on the right spot / "Should this be done here?"
  • UI changes fits into the layout
  • The UI views / components are responsive (mobile views)
  • Correct translations are available

Checklist for branch merge request (not required for forks)

@fscholdei fscholdei added the bug Something isn't working label Jun 1, 2022
@Pilopa Pilopa merged commit ef8f803 into develop Jun 1, 2022
@Pilopa Pilopa deleted the bugfix/confirm_alert_button branch June 1, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants