Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes NullPointerException in update steps #1244

Merged
merged 1 commit into from Jul 8, 2020

Conversation

pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Jul 8, 2020

Proposed changes

There may be v1 properties with key/value pairs, where the value is not
set. Such "pairs" led to a null pointer exception in the map function,
because no Optional could be created for the null value.
To solve this, we filter such properties without value in the beginning,
because these properties would create a null result both ways.

Fixes #1237

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • CHANGELOG.md updated
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@pfeuffer pfeuffer added the bug Something isn't working label Jul 8, 2020
There may be v1 properties with key/value pairs, where the value is not
set. Such "pairs" led to a null pointer exception in the `map` function,
because no Optional could be created for the null value.
To solve this, we filter such properties without value in the beginning,
because these properties would create a null result both ways.
@pfeuffer pfeuffer force-pushed the bugfix/read_v1_props_without_value branch from 3479d99 to f8da4ce Compare July 8, 2020 06:27
@eheimbuch eheimbuch merged commit c8d483a into develop Jul 8, 2020
@eheimbuch eheimbuch deleted the bugfix/read_v1_props_without_value branch July 8, 2020 06:44
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation redmine plugin fails
2 participants