Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "links" collection to index resources, again #1594

Merged
merged 2 commits into from Mar 17, 2021

Conversation

pfeuffer
Copy link
Member

@pfeuffer pfeuffer commented Mar 17, 2021

Proposed changes

With the introduction of react-query, it looks like the indexResources attribute of the repository initialization extension properties lost its collection links, which was replaces by _links. In this fix we copy this collection, so that the template plugin still can use links.

Fixes #1593

Your checklist for this pull request

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • Changelog entry file created in gradle/changelog
  • Definition of Done's fulfilled: DoD // UI DoD

Checklist for branch merge request (not required for forks)

@pfeuffer pfeuffer force-pushed the bugfix/index_links_in_extension_points branch from a87b1ae to 287daa1 Compare March 17, 2021 07:12
@pfeuffer pfeuffer force-pushed the bugfix/index_links_in_extension_points branch from 287daa1 to fd89f85 Compare March 17, 2021 07:15
@pfeuffer pfeuffer force-pushed the bugfix/index_links_in_extension_points branch from 1465415 to 306f8b0 Compare March 17, 2021 07:33
@pfeuffer pfeuffer marked this pull request as ready for review March 17, 2021 07:34
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@eheimbuch eheimbuch merged commit d8092be into develop Mar 17, 2021
@eheimbuch eheimbuch deleted the bugfix/index_links_in_extension_points branch March 17, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin Repository Template not working anymore
2 participants