Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns 404 for valid endpoints if it's not fully loaded #20

Open
aramirez-es opened this issue Nov 30, 2015 · 4 comments
Open

Returns 404 for valid endpoints if it's not fully loaded #20

aramirez-es opened this issue Nov 30, 2015 · 4 comments
Labels

Comments

@aramirez-es
Copy link
Contributor

Since last update, the behavior changed a bit, as described here:

Previous to 1.4.1

  • First run the app
$ gradlew clean runApp
. . .
2015-11-30 11:27:18 INFO  log:67 - Started SocketConnector@0.0.0.0:8077
  • At this point if you request a valid endpoint, that request will be blocked until the whole server to be up. Then the response is the expected.
  • Following requests will be server without blocking.

From 1.4.1 on

  • First run the app
$ gradlew clean runApp
. . .
2015-11-30 11:27:18 INFO  log:67 - Started SocketConnector@0.0.0.0:8077
  • At this point if you request a valid endpoint, that request will return a 404 since the whole server is not up yet.
  • Following requests will be server as expected.

What's the expected behavior?

@fiunchinho
Copy link
Contributor

I think it shouldn't return a 404. Previous behavior was the expected.

@aramirez-es
Copy link
Contributor Author

I agree @fiunchinho, indeed it may cause a undesired behavior in a context of: high concurrency, continuous delivery and micro caching. 404 may be cached for a while and lot of requests to get a unexpected response.

@padilo
Copy link

padilo commented Dec 2, 2015

I agree too, It should work as previous versions.

While looking to solve this, It seems that now the package property is required, if not specified it doesn't register any endpoint.

To workaround this just set this the property 'com.scmspain.karyon.rest.property.packages' with the package to look for endpoints.

Please, change the label to bug :)

@padilo
Copy link

padilo commented Dec 21, 2015

I think now is solved, if someone can check it or thinks is solved please close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants