This repository has been archived by the owner on Dec 11, 2018. It is now read-only.
Jacob Ibáñez #35
Open
Jacob Ibáñez #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t] Test passing with simplest but not best implementation.
…t] Test passing with better solution.
Iakobs
commented
Aug 31, 2018
| @@ -4,7 +4,6 @@ | |||
| import com.scmspain.configuration.TweetConfiguration; | |||
| import org.springframework.boot.SpringApplication; | |||
| import org.springframework.boot.autoconfigure.EnableAutoConfiguration; | |||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | |||
There was a problem hiding this comment.
I'm curious about that... if I put the @SpringBootApplication annotation, the tests fail, ¿why is that?
Nevertheless, a unused import must be erased.
…t] Yay! A test was failing!
…not best implementation.
|
The test is finished. Nevertheless, the specifications in the [As a User, I want to add links to the tweet text without affecting the 140 character limit] User Story are not clear enough. As it is implemented right now, an infinite tweet can bypass the validation simply by omitting any spaces after the http sequence. In the future, the Product Owner should clarify if this is correct or not, or the scrum team in the refinement meeting should say if this User Story meets the Definition Of Ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.