Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compat #163

Closed
wants to merge 2 commits into from
Closed

Windows compat #163

wants to merge 2 commits into from

Conversation

AsaAyers
Copy link

Fixes scm_breeze/#135

I'm trying to use the version of bash that comes with git. These are the changes I had to make so far.

@AsaAyers
Copy link
Author

The number expansion is broken now and I don't know why. if I try to use the numbers rm 1 it becomes /bin/rm1 and then tries to execute whatever file I was pointing at.

edit: rm $e1 works fine though.

@AsaAyers
Copy link
Author

https://github.com/AsaAyers/scm_breeze/blob/windows-compat/lib/git/branch_shortcuts.sh#L24

When scm_breeze invokes ruby, it's subprocess isn't running bash so /bin/git doesn't exist. It needs to somehow find c:\Program Files (x86)\Git\cmd\git.exe instead.

@zommerfelds
Copy link
Contributor

zommerfelds commented Feb 17, 2017

I don't have the exact same issue, I was getting C:/Users/czommerfelds/.scm_breeze/lib/git/status_shortcuts.rb:29:in `<main>': undefined method `[]' for nil:NilClass (NoMethodError) when running gs.
I uninstalled Ruby and that got fixed. Probably due to the same problem you mentioned.

@ghthor
Copy link
Member

ghthor commented Feb 17, 2017

@zommerfelds are you saying that without ruby installed scm_breeze is now working for you on windows?

@zommerfelds
Copy link
Contributor

@ghthor: yes

@zommerfelds
Copy link
Contributor

@ghthor: I use it inside Git Bash (https://git-for-windows.github.io/)

@ghthor
Copy link
Member

ghthor commented Feb 17, 2017

That seems extraordinary. Perhaps Git Bash is providing a newer version of ruby that has support for the syntax used in the scm_breeze scripts?

@zommerfelds
Copy link
Contributor

No I don't think it provides any Ruby version. As far as I understand scm_breeze has a Bash (non-Ruby) version, and that one seems to work.

@zommerfelds
Copy link
Contributor

@ghthor: NVM, gb doesn't work without Ruby bash: ruby: command not found

@AsaAyers
Copy link
Author

I'm making https://github.com/pulls more useful to me today by closing my old PRs.

@AsaAyers AsaAyers closed this Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants