inlined imports should be rebased to current file #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My problem is related to #42
Problem description
File
import.css
:File
otherdir/imported.css
Will fail by:
with an Exception that
../otherdir/imported.css
can not be resolved.I had expected an outcome like this:
minified 'import.css':
I was not able to fix this problem by configuration, because the path of the current file is required to correct the
rebaseTo
option.Solution
This fix always transports the file.path together with the contents to CleanCss.minify, which enables the imports of relative files.
A second problem occurred when
inline: ['local']
is required. The image URLs defined in the imported css files were unexpected rebased to the current working directory. I had expected a rebase relative to the current file, so that the browser can import e.g. all images relative from the minified css file. Like in the sample above.The patch ensures that the rebaseTo option is defined as the parent directory of the current processed file if not otherwise specified.