read() in inputstream should return unsigned value #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpilquist
reviewed
Apr 25, 2022
| @@ -2262,7 +2262,8 @@ object ByteVector extends ByteVectorCompanionCrossPlatform { | |||
| private val bvlen = bv.size.toInt | |||
| private val pos = new CustomAtomicInteger(0) | |||
|
|
|||
| override def read(): Int = bv.get(pos.getAndIncrement().toLong) | |||
| override def read(): Int = | |||
| if (pos.get() >= bvlen) -1 else bv.get(pos.getAndIncrement().toLong) & 0xff | |||
There was a problem hiding this comment.
Safer to get current value of pos once instead of calling it twice here.
val p = pos.getAndIncrement()
if (p >= bvlen) -1
else bv.get(p.toLong) & 0xffThere was a problem hiding this comment.
I don't think it is a good idea, since available then will return negative values if read() is called at the end of the stream.
There was a problem hiding this comment.
Okay, my concern is with thread safety - a race between concurrent read calls and an interleaving of get/get/getAndIncrement/getAndOncrement.
There was a problem hiding this comment.
Ah I see. So a fix could be in available() instead I guess.
|
Thanks for spotting & fixing. Can we add a unit test for this as well? |
|
@mpilquist I have added a small test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
read()should return a value between 0 and 255 (https://docs.oracle.com/javase/9/docs/api/java/io/InputStream.html#read--)