-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add "Business Rules Engine" metadata support for v57+ #644
feat: add "Business Rules Engine" metadata support for v57+ #644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job so far !
It is nearly ready 👏
I think the v55
and v56
files should not be changed because those metadata are available since v57 according to the doc.
Also the folder should be updated to match the one described in the doc (cf the inline comments)
Documentation:
- https://developer.salesforce.com/docs/atlas.en-us.industries_reference.meta/industries_reference/meta_businessprocesstypedefinition.htm?q=BusinessProcessTypeDefinitions
- https://developer.salesforce.com/docs/atlas.en-us.industries_reference.meta/industries_reference/meta_applicationsubtypedefinition.htm
- https://developer.salesforce.com/docs/atlas.en-us.industries_reference.meta/industries_reference/meta_explainabilityactionversion.htm
- https://developer.salesforce.com/docs/atlas.en-us.industries_reference.meta/industries_reference/meta_explainabilityactiondefinition.htm
Code Climate has analyzed commit 13c2c9a and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #644 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 891 891
=========================================
Hits 891 891 ☔ View full report in Codecov by Sentry. |
Have you been able to test this PR locally @willianmatheus98 ? |
Yes, here is a file generated in my local machine <?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
<types>
<members>PtyRelaGrp</members>
<name>ApplicationSubtypeDefinition</name>
</types>
<types>
<members>GroupAudit</members>
<name>BusinessProcessTypeDefinition</name>
</types>
<types>
<members>PartyRelationshipGroupAuditLog</members>
<name>ExplainabilityActionDefinition</name>
</types>
<types>
<members>PartyRelationshipGroupAuditLog</members>
<name>ExplainabilityActionVersion</name>
</types>
<version>58.0</version>
</Package> |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.23.0 |
Explain your changes
Add
ExplainabilityActionDefinition
metadata type supportAdd
ExplainabilityActionVersion
metadata type supportAdd
ApplicationSubtypeDefinition
metadata type supportAdd
BusinessProcessTypeDefinitions
metadata type supportDoes this close any currently open issues?
Any particular element that can be tested locally
Any other comments