Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Business Rules Engine" metadata support for v57+ #644

Merged

Conversation

willianmatheus98
Copy link
Contributor

Explain your changes


Add ExplainabilityActionDefinition metadata type support
Add ExplainabilityActionVersion metadata type support
Add ApplicationSubtypeDefinition metadata type support
Add BusinessProcessTypeDefinitions metadata type support

Does this close any currently open issues?


Any particular element that can be tested locally


Any other comments


Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/metadata/v57.json Outdated Show resolved Hide resolved
src/metadata/v57.json Outdated Show resolved Hide resolved
src/metadata/v57.json Outdated Show resolved Hide resolved
src/metadata/v57.json Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jun 28, 2023

Code Climate has analyzed commit 13c2c9a and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@scolladon scolladon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willianmatheus98 willianmatheus98 changed the title Added missing BRE (Business Rules Engine) metadata feat: Added missing BRE (Business Rules Engine) metadata Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7a69ed0) 100.00% compared to head (13c2c9a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #644   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          891       891           
=========================================
  Hits           891       891           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scolladon scolladon changed the title feat: Added missing BRE (Business Rules Engine) metadata feat: add "Business Rules Engine" metadata support for v57+ Jun 28, 2023
@scolladon
Copy link
Owner

Have you been able to test this PR locally @willianmatheus98 ?

@willianmatheus98
Copy link
Contributor Author

Have you been able to test this PR locally @willianmatheus98 ?

Yes, here is a file generated in my local machine

<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
    <types>
        <members>PtyRelaGrp</members>
        <name>ApplicationSubtypeDefinition</name>
    </types>
    <types>
        <members>GroupAudit</members>
        <name>BusinessProcessTypeDefinition</name>
    </types>
    <types>
        <members>PartyRelationshipGroupAuditLog</members>
        <name>ExplainabilityActionDefinition</name>
    </types>
    <types>
        <members>PartyRelationshipGroupAuditLog</members>
        <name>ExplainabilityActionVersion</name>
    </types>
    <version>58.0</version>
</Package>

@scolladon scolladon merged commit 7d915a2 into scolladon:main Jun 30, 2023
17 of 19 checks passed
@github-actions
Copy link

Shipped in release v5.23.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.23.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants