Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use constant for path separator #766

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: use constant for path separator #766

merged 1 commit into from
Jan 25, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Use constant for path separator

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e6d6e34) 100.00% compared to head (7401a12) 99.80%.

❗ Current head 7401a12 differs from pull request most recent head 8765c84. Consider uploading reports for the commit 8765c84 to get more accurate results

Files Patch % Lines
src/utils/fsHelper.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #766      +/-   ##
===========================================
- Coverage   100.00%   99.80%   -0.20%     
===========================================
  Files           37       37              
  Lines         1040     1049       +9     
  Branches       113      113              
===========================================
+ Hits          1040     1047       +7     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codeclimate bot commented Jan 25, 2024

Code Climate has analyzed commit 7401a12 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit e8cd848 into main Jan 25, 2024
38 of 40 checks passed
@scolladon scolladon deleted the fix/slice-issue branch January 25, 2024 10:45
Copy link

Shipped in release v5.35.1.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.35.1

Happy incremental deployment!

a-ursu added a commit to deloitte-engineering/sfdx-git-delta that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant