Removed dependency on DOM in CommonMobileModule, fixed #3

docs/index.md

@@ -34,6 +34,10 @@ val scommonsResourcesArtifacts: SettingKey[Seq[ModuleID]] = settingKey[Seq[Modul
 val scommonsBundlesFileFilter: SettingKey[FileFilter] = settingKey[FileFilter](
   "File filter of bundles files, that should be automatically generated in the webpack directory"
 )
+
+val scommonsNodeJsTestLibs: SettingKey[Seq[String]] = settingKey[Seq[String]](
+  "List of JavaScript files, that should be pre-pended to the test fastOptJS output, useful for module mocks"
+)
 ```
 
 With default values:
@@ -54,14 +58,16 @@ scommonsResourcesFileFilter :=
     "*.mp4" ||
     "*.mov" ||
     "*.html" ||
-    "*.pdf"
+    "*.pdf",
 
 scommonsResourcesArtifacts := Seq(
   "org.scommons.react" % "scommons-react-core" % "*",
   "org.scommons.client" % "scommons-client-ui" % "*"
-)
+),
 
-scommonsBundlesFileFilter := NothingFilter
+scommonsBundlesFileFilter := NothingFilter,
+
+scommonsNodeJsTestLibs := Nil
 ```
 
 You can extend/override the default values:
@@ -76,7 +82,11 @@ settings(
 
     // will generate bundle.json file(s) with migrations for SQLite
     // see `scommons-websql-migrations` module
-    scommonsBundlesFileFilter := "*.sql"
+    scommonsBundlesFileFilter := "*.sql",
+
+    // to substitute references to react-native modules
+    // with our custom mocks during test
+    scommonsNodeJsTestLibs := Seq("scommons.reactnative.aliases.js")
 )
 ```
 

src/main/scala/scommons/sbtplugin/ScommonsPlugin.scala

@@ -24,6 +24,10 @@ object ScommonsPlugin extends AutoPlugin {
     val scommonsBundlesFileFilter: SettingKey[FileFilter] = settingKey[FileFilter](
       "File filter of bundles files, that should be automatically generated in the webpack directory"
     )
+
+    val scommonsNodeJsTestLibs: SettingKey[Seq[String]] = settingKey[Seq[String]](
+      "List of JavaScript files, that should be pre-pended to the test fastOptJS output, useful for module mocks"
+    )
   }
 
   import autoImport._
@@ -55,11 +59,34 @@ object ScommonsPlugin extends AutoPlugin {
 
     scommonsBundlesFileFilter := NothingFilter,
 
+    scommonsNodeJsTestLibs := Nil,
+
     sjsStageSettings(fastOptJS, Compile),
     sjsStageSettings(fullOptJS, Compile),
     sjsStageSettings(fastOptJS, Test),
     sjsStageSettings(fullOptJS, Test),
 
+    fastOptJS in Test := {
+      val logger = streams.value.log
+      val testLibs = scommonsNodeJsTestLibs.value
+      val sjsOutput = (fastOptJS in Test).value
+      if (testLibs.nonEmpty) {
+        val sjsOutputName = sjsOutput.data.name.stripSuffix(".js")
+        val targetDir = sjsOutput.data.getParentFile
+        val bundle = new File(targetDir, s"$sjsOutputName-bundle.js")
+
+        logger.info(s"Writing NodeJs test bundle\n\t$bundle")
+        IO.delete(bundle)
+        testLibs.foreach { jsFile =>
+          IO.write(bundle, IO.read(new File(targetDir, jsFile)), append = true)
+        }
+        IO.write(bundle, IO.read(sjsOutput.data), append = true)
+
+        Attributed(bundle)(sjsOutput.metadata)
+      }
+      else sjsOutput
+    },
+
     // revert the change for clean task: https://github.com/sbt/sbt/pull/3834/files#r172686677
     // to keep the logic for cleanKeepFiles and avoid the error:
     //   cleanKeepFiles contains directory/file that are not directly under cleanFiles

src/main/scala/scommons/sbtplugin/project/CommonMobileModule.scala

@@ -8,7 +8,6 @@ import sbt._
 import scommons.sbtplugin.ScommonsPlugin.autoImport._
 import scommons.sbtplugin.project.CommonModule.ideExcludedDirectories
 
-import scalajsbundler.ExternalCommand
 import scalajsbundler.sbtplugin.ScalaJSBundlerPlugin
 import scalajsbundler.sbtplugin.ScalaJSBundlerPlugin.autoImport._
 
@@ -21,12 +20,8 @@ trait CommonMobileModule extends CommonModule {
       .enablePlugins(ScalaJSPlugin, ScalaJSBundlerPlugin)
       .settings(CommonMobileModule.settings: _*)
       .settings(
-        scalaJSUseMainModuleInitializer := false,
-        webpackBundlingMode := BundlingMode.LibraryOnly(),
-
-        webpackConfigFile in Test := Some(
-          baseDirectory.value / "src" / "test" / "resources" / "test.webpack.config.js"
-        )
+        // we substitute references to react-native modules with our custom mocks during test
+        scommonsNodeJsTestLibs := Seq("scommons.reactnative.aliases.js")
       )
   }
 
@@ -59,35 +54,14 @@ object CommonMobileModule {
     ),
 
     scalaJSModuleKind := ModuleKind.CommonJSModule,
+    scalaJSUseMainModuleInitializer := false,
+    webpackBundlingMode := BundlingMode.LibraryOnly(),
 
     //Opt-in @ScalaJSDefined by default
     scalacOptions += "-P:scalajs:sjsDefinedByDefault",
 
-    // react-native DO NOT require DOM, but we enable it here only to trigger the webpack build
-    // since we substitute references to react-native module with our custom react-native-mocks module
-    // inside the sc-react-native-mocks.webpack.config.js
-    requireJsDomEnv in Test := true,
-    installJsdom := {
-      val jsdomVersion = (version in installJsdom).value
-
-      val installDir = target.value / "scalajs-bundler-jsdom"
-      val baseDir = baseDirectory.value
-      val jsdomDir = installDir / "node_modules" / "jsdom"
-      val log = streams.value.log
-      if (!jsdomDir.exists()) {
-        log.info(s"Installing jsdom into: ${installDir.absolutePath}")
-        IO.createDirectory(installDir / "node_modules")
-        ExternalCommand.addPackages(
-          baseDir,
-          installDir,
-          useYarn.value,
-          log,
-          npmExtraArgs.value,
-          yarnExtraArgs.value
-        )(s"jsdom@$jsdomVersion")
-      }
-      installDir
-    },
+    // react-native DO NOT require DOM
+    requireJsDomEnv in Test := false,
 
     version in webpack := "3.5.5",
 
@@ -106,6 +80,9 @@ object CommonMobileModule {
       "react" -> "^16.8.0",
       "react-dom" -> "^16.8.0"
     ),
+    npmDevDependencies in Test ++= Seq(
+      "module-alias" -> "2.2.2"
+    ),
 
     ideExcludedDirectories ++= {
       val base = baseDirectory.value