Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate_features_pred room for optimization? #2

Closed
rvarun7777 opened this issue Sep 11, 2020 · 1 comment
Closed

Generate_features_pred room for optimization? #2

rvarun7777 opened this issue Sep 11, 2020 · 1 comment

Comments

@rvarun7777
Copy link

rvarun7777 commented Sep 11, 2020

In the Generate_features_pred function as pointed below:

outputs = self.generate_features_pred(inputs, outputs)

I see that you are using only the scale 0 features. But the calculation takes place for all the 4 scales.
I believe, it can be calculated only once.

disp = outputs[("disp", 0, 0)]

outputs[("feature", frame_id, 0)] = F.grid_sample(src_f, pix_coords, padding_mode="border")

@sconlyshootery
Copy link
Owner

Yes, you're right, thank you for your advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants