Rails 4 and 4.1 adapters #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please accept this pull request. I had the same issue with Rails 4.0.3. After spending much time trying to fix it, I finally found this solution, and it works. |
|
I can verify that this issue exists with rspec 2.14 as well as rspec 3.0 beta. |
|
Any chance this or something equivalent can be merged in? |
|
Thanks, I'm currently slogging through the backlog (for some reason it's easier to work on open source projects when I'm unemployed, go figure). I'll accept this once I merge my personal fork to sconover/master . |
|
I've checked Rails 4.2 with wrong and added the missing clause, too. I also rebased on the current master. |
|
bump? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Wrong work together with Rails 4.0 and 4.1beta1.
fixes #41