fix(kcov,povray): quote array expansions to avoid extra processing

The raw assignment can be affected by word splitting and pathname expansions.
scop · Dec 24, 2023 · 215edab · 215edab
1 parent f98379d
commit 215edab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/completions/kcov b/completions/kcov
@@ -36,7 +36,7 @@ _comp_cmd_kcov()
                     COMPREPLY=(${COMPREPLY/#/$prev,})
             else
                 _comp_compgen -- -W "{0..100}"
-                ((${#COMPREPLY[@]} == 1)) && COMPREPLY=(${COMPREPLY/%/,})
+                ((${#COMPREPLY[@]} == 1)) && COMPREPLY=("${COMPREPLY/%/,}")
                 compopt -o nospace
             fi
             return

diff --git a/completions/povray b/completions/povray
@@ -35,8 +35,8 @@ _comp_cmd_povray()
                 IFS=$'\n'
                 command grep '^[-+]I' <<<"${words[*]}"
             ))
-            COMPREPLY=(${COMPREPLY[@]#[-+]I})
-            COMPREPLY=(${COMPREPLY[@]/%.pov/.$oext})
+            _comp_compgen -Rv COMPREPLY -- -X '' -W '"${COMPREPLY[@]#[-+]I}"'
+            COMPREPLY=("${COMPREPLY[@]/%.pov/.$oext}")
             cur="${povcur#[-+]O}" # to confuse _comp_compgen_filedir
             pfx="${povcur%"$cur"}"
             _comp_compgen -a filedir $oext