Skip to content

Commit

Permalink
fix(perl): fix ineffective condition in an awk script
Browse files Browse the repository at this point in the history
The condition `$NF=2` in the awk script actually assigns a value `2`
to the last field instead of comparing it to `2` and always evaluates
to true.  I suspect it to be `NF >= 2`.

This could possibly be intended as `NF == 2` or `$NF == 2`, but
neither seems to work correctly.  The input contains the names of man
entries of the form ` perlxx <description>`, but the description is
usually given by more than one words, so restricting them by `NF == 2`
would be unreasonable.  On the other hand, there are no entries ending
with the word `2` so `$NF == 2` would produce no results.  This
condition was introduced from the beginning when the related code was
introduced in commit 4254f3a.  There does not seem to be any hints on
the background of `$NF=2`.
  • Loading branch information
akinomyoga committed Nov 27, 2023
1 parent cdd6da9 commit 302dc52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion completions/perl
Expand Up @@ -132,7 +132,7 @@ _comp_cmd_perldoc()
if [[ $cur == p* ]]; then
_comp_compgen -a split -- "$(PERLDOC_PAGER=cat "$1" -u perl |
command sed -ne '/perl.*Perl overview/,/perlwin32/p' |
awk '$NF=2 && $1 ~ /^perl/ { print $1 }')"
awk 'NF >= 2 && $1 ~ /^perl/ { print $1 }')"
fi
fi
_comp_compgen -a filedir 'p@([lm]|od)'
Expand Down

0 comments on commit 302dc52

Please sign in to comment.