java, pkgadd, sysbench: address shellcheck SC2124

scop · Mar 26, 2020 · 5757fd4 · 5757fd4
1 parent a6e5e99
commit 5757fd4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/completions/java b/completions/java
@@ -116,7 +116,7 @@ _java_packages()
     # remove packages extension
     COMPREPLY=( ${COMPREPLY[@]%/} )
     # convert path syntax to package syntax
-    cur=${COMPREPLY[@]//\//.}
+    cur="${COMPREPLY[@]//\//.}"
 }
 
 # java completion

diff --git a/completions/pkgadd b/completions/pkgadd
@@ -41,9 +41,10 @@ _pkgadd ()
             else
                 local pkginst_list
                 if [[ -d $device ]]; then
+                    local -a tmplist
                     for filedir in $(/bin/ls -1 $device); do
                         if [[ -d "$device/$filedir" ]] && [[ -f "$device/$filedir/pkginfo" ]]; then
-                            pkginst_list+=( ${pkginst_list[@]:-} "$filedir" )
+                            tmplist+=( ${tmplist[@]:-} "$filedir" )
                         fi
                     done
                         pkginst_list="${pkginst_list[@]}"

diff --git a/completions/sysbench b/completions/sysbench
@@ -116,7 +116,7 @@ _sysbench()
     local opts=$(_parse_help "$1")
     if [[ $test ]]; then
         local help=( $(_parse_help "$1" "--test=$test help") )
-        opts="${opts[@]/--test=/} ${help[@]} prepare run cleanup help version"
+        opts="${opts/--test=/} ${help[@]} prepare run cleanup help version"
     fi
 
     if [[ "$cur" == -* || ! $test ]]; then