Quote _filedir arguments when appropriate to prevent failglob failures

scop · Jun 4, 2014 · 8566a5a · 8566a5a
1 parent 24c8f1e
commit 8566a5a
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/completions/cppcheck b/completions/cppcheck
@@ -81,7 +81,7 @@ _cppcheck()
         COMPREPLY=( $( compgen -W '$( _parse_help "$1" )' -- "$cur" ) )
         [[ $COMPREPLY == *= ]] && compopt -o nospace
     else
-        _filedir @([cht]pp|[cht]xx|cc|[ch]++|[ch])
+        _filedir '@([cht]pp|[cht]xx|cc|[ch]++|[ch])'
     fi
 } &&
 complete -F _cppcheck cppcheck

diff --git a/completions/installpkg b/completions/installpkg
@@ -26,7 +26,7 @@ _installpkg()
         return 0
     fi
 
-    _filedir "t[bglx]z"
+    _filedir 't[bglx]z'
 } && complete -F _installpkg installpkg
 
 # ex: ts=4 sw=4 et filetype=sh
diff --git a/completions/k3b b/completions/k3b
@@ -23,7 +23,7 @@ _k3b()
             return 0
             ;;
         --cdimage|--image)
-            _filedir @(cue|iso|toc)
+            _filedir '@(cue|iso|toc)'
             return 0
             ;;
         --dvdimage)

diff --git a/completions/sqlite3 b/completions/sqlite3
@@ -22,7 +22,7 @@ _sqlite3()
         return 0
     fi
 
-    _filedir $dbexts
+    _filedir "$dbexts"
 } &&
 complete -F _sqlite3 sqlite3
 

diff --git a/completions/tar b/completions/tar
@@ -27,7 +27,7 @@ _tar()
                     *[jy]*) ext='t@(?(ar.)bz?(2)|b2)' ;;
                     *J*)    ext='t?(ar.)xz'           ;;
                 esac
-                _filedir $ext
+                _filedir "$ext"
             else
                 _filedir
             fi

diff --git a/completions/upgradepkg b/completions/upgradepkg
@@ -23,7 +23,7 @@ _upgradepkg()
         return
     fi
 
-    _filedir "t[bglx]z"
+    _filedir 't[bglx]z'
 } && complete -F _upgradepkg upgradepkg
 
 # ex: ts=4 sw=4 et filetype=sh