dd: Sync completions with coreutils 8.24

scop · Sep 13, 2016 · 8b35dd3 · 8b35dd3
1 parent 78b0543
commit 8b35dd3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 4 deletions.
diff --git a/completions/dd b/completions/dd
@@ -14,16 +14,29 @@ _dd()
         conv=*)
             cur=${cur#*=}
             COMPREPLY=( $( compgen -W 'ascii ebcdic ibm block unblock lcase
-                notrunc ucase swab noerror sync' -- "$cur" ) )
+                ucase sparse swab sync excl nocreat notrunc noerror fdatasync
+                fsync' -- "$cur" ) )
+            return
+            ;;
+        iflag=*|oflag=*)
+            cur=${cur#*=}
+            COMPREPLY=( $( compgen -W 'append direct directory dsync sync
+                fullblock nonblock noatime nocache noctty nofollow count_bytes
+                skip_bytes seek_bytes' -- "$cur" ) )
+            return
+            ;;
+        status=*)
+            cur=${cur#*=}
+            COMPREPLY=( $( compgen -W 'none noxfer progress' -- "$cur" ) )
             return
             ;;
     esac
 
     _expand || return
 
     COMPREPLY=( $( compgen -W '$( _parse_help "$1" )' -- "$cur" ) \
-                $( compgen -W 'bs cbs conv count ibs if obs of seek skip' \
-                    -S '=' -- "$cur" ) )
+                $( compgen -W 'bs cbs conv count ibs if iflag obs of oflag
+                               seek skip status' -S '=' -- "$cur" ) )
 } &&
 complete -F _dd -o nospace dd
 

diff --git a/test/lib/completions/dd.exp b/test/lib/completions/dd.exp
@@ -18,7 +18,7 @@ sync_after_int
 
 
 set test "option should be suffixed with ="
-set cmd "dd if"
+set cmd "dd bs"
 send "$cmd\t"
 expect -ex "$cmd"
 expect {