Skip to content

Commit

Permalink
test: remove shellcheck severity filter, add explicit disables instead
Browse files Browse the repository at this point in the history
  • Loading branch information
scop committed Apr 25, 2020
1 parent 5e5c83b commit fd19ea0
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 5 deletions.
5 changes: 1 addition & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ repos:
rev: v0.7.1.1
hooks:
- id: shellcheck
args: [
-S, warning, # https://github.com/koalaman/shellcheck/issues/1554
-f, gcc,
]
args: [-f, gcc]
types: [text]
files: ^(bash_completion|completions/.+|test/run*|.+\.sh(\.in)?)$
exclude: completions/(\.gitignore|Makefile.*)$
Expand Down
19 changes: 18 additions & 1 deletion .shellcheckrc
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,23 @@ shell=bash
disable=SC1090 # not really fixable usually (ever?)
disable=SC2034 # for localizing variables set in called functions
disable=SC2128 # intentional style choice
disable=SC2155 # TODO
disable=SC2206 # suggested alternatives fail in posix mode or use temp files
disable=SC2207 # suggested alternatives fail in posix mode or use temp files

# These disables are to be investigated and decided

disable=SC1003
disable=SC1004
disable=SC2002
disable=SC2004
disable=SC2006
disable=SC2015
disable=SC2016
disable=SC2035
disable=SC2086
disable=SC2102
disable=SC2116
disable=SC2155
disable=SC2162
disable=SC2231
disable=SC2236

0 comments on commit fd19ea0

Please sign in to comment.