bind: add variable and fix function completion #352
Conversation
Add completion to the common invocation forms of:
bind 'set variable-name value'
and
bind '"keyseq":function-name'
multiple separate readline commands can be supplied, putting in the check for `[[ $cword -gt 1 ]]` was a mistake.
| for v in "${vals[@]}"; do | ||
| [[ $v == "$val"* ]] && COMPREPLY+=("${pre}${val}${v/#$val}") | ||
| done | ||
| eval "$reset" |
There was a problem hiding this comment.
I was thinking eval "$reset" might be a better/cleaner construct to use in these cases, rather than doing the $IFS switcheroo, since eval "$reset" works the same way regardless of $IFS value and so doesn't require protection from non-default values. Curious what you think.
There was a problem hiding this comment.
Consistency and eval avoidance are good things to pursue.
| _bind_vars() | ||
| { | ||
| local pre=$1 var=$2 | ||
| local v reset=$(shopt -p nocasematch); shopt -s nocasematch |
completions/bind
Outdated
| local v reset=$(shopt -p nocasematch); shopt -s nocasematch | ||
| while IFS=' ' read _ v _; do | ||
| [[ $v == "$var"* ]] && COMPREPLY+=("${pre}${var}${v/#$var}") | ||
| done < <(bind -v) |
There was a problem hiding this comment.
Got it. Replaced with a command substitution approach.
| _bind() | ||
| { | ||
| local cur prev words cword | ||
| _init_completion || return | ||
| local cur prev words cword IFS=$'\n' |
There was a problem hiding this comment.
Hm, this might actually provide for the IFS protection I mentioned above. Right?
There was a problem hiding this comment.
I think IFS would have to contain a space in order for the expansion of $reset to be evaluated as separate words
scop
force-pushed
the
master
branch
3 times, most recently
from
c0e9459
to
09307f8
Compare
This adds completion to the common invocation forms of:
and
A little tricky because the whole argument is likely to be quoted and/or has colons in it.
Supported completions (works w/ or w/o
:in$COMP_WORDBREAKS):The variable names and values are completed in a case-insensitive and case-preserving manner.
I added some test but they seem to all be getting skipped, unless I put the
_bind()function definition first in the file -- not sure what's up with that.