Adding a completion for $cryptsetup luksChangeKey #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Hugo, thanks for writing this. From a cryptsetup perspective, the change looks good to me . I would recommend, though, that you write a more descriptive commit message, explaining that luksChangeKey accepts the same arguments as luksAddKey and luksRemoveKey, since they all operate on keys in the luks header. Also, this pull request seems to address issue #197, so you could add a "Fix #197" sentence to your commit message, so that the associated issue gets closed automatically. |
This command accepts the same arguments as luksAddKey and luksRemoveKey and they all operate on keys in the luks header. 'Fix scop#197'
|
Thanks @hugoziviani for the code and @gftg85 for the review. Squashed and commit message further tweaked a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a completion for $cryptsetup luksChangeKey