New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mutt: handle neomutt -Q var correctly #463
base: main
Are you sure you want to change the base?
Conversation
This is the same code I submitted upstream as scop/bash-completion#463 It Works For Me (TM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Packages get included in docker images automatically, the image builds reference test/test-cmd-list.txt
to determine what gets pulled in, and that file is updated using test/update-test-cmd-list
. If neomutt was installed as an alias to mutt and had some unit tests, that'd be enough to get it included.
Anyway the tests can be run locally without docker too, see doc/testing.txt
Also allow multiple spaces in case there ever are any. Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
neomutt in debian buster (10) is old enough that it still prints using the old output format. neomutt in ubuntu 20.04 is using the new format, but it looks like your .travis.yml runs against ubuntu14. (neomutt in ubuntu 18.04 also uses the old format.) I don't know how to check package names and versions available for centos, fedora or alpine. The name 'fedoradev' seems promising if one wants fresh new package versions. Anyway it looks like testing this properly would need #466 to be merged as well. |
So I have some tests in #467. In my environment 'mutt' is an alias for 'neomutt', so the tests I added fail without this fix. I could copy the (I don't see any Travis builds here, but I do get them on my fork: https://travis-ci.com/github/mgedmin/bash-completion/branches. |
c0e9459
to
09307f8
Compare
The
$muttcmd -Q ... | sed ...
invocation was repeated in three places, so I've extracted it into a new helper function_muttconfvar()
.Closes #462.
(I looked into adding a test, but I'm not sure how. It looks like the tests are executed in Docker, but I couldn't figure out what packages are included there or how to add neomutt.)