fix(_comp_command_offset): fix offset mismatching for words vs COMP_WORDS (use words) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
changed the title
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
3 times, most recently
from
32f077e
to
25d5f8f
Compare
|
I have rebased it on top of the latest master and added adjustments to the existing interfaces in commit 25d5f8f. |
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
25d5f8f
to
3842c49
Compare
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
3842c49
to
440abbf
Compare
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
440abbf
to
f0b7d24
Compare
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
f0b7d24
to
717b98a
Compare
scop
requested changes
Apr 17, 2023
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
2 times, most recently
from
6251f46
to
e1ace64
Compare
scop
approved these changes
May 1, 2023
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
750a244
to
bfc752b
Compare
|
I have applied the suggested changes to the code comments and squashed them into the corresponding commit. I added an additional adjustment as follows:
|
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
bfc752b
to
d9aed51
Compare
Co-authored-by: Ville Skyttä <ville.skytta@iki.fi>
akinomyoga
force-pushed
the
_command_offset-offsetMismatch
branch
from
d9aed51
to
06bfe23
Compare
|
Thanks. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #722.
This fixes it the other way around as #802. Now
_comp_command_offsetreceives the index inwordsinstead of that inCOMP_WORDS.