Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Per OS/arch or per URL exe in archive path #19

Closed
scop opened this issue Nov 15, 2023 · 1 comment · Fixed by #22
Closed

Per OS/arch or per URL exe in archive path #19

scop opened this issue Nov 15, 2023 · 1 comment · Fixed by #22

Comments

@scop
Copy link
Owner

scop commented Nov 15, 2023 •
edited
Loading

The common case is tool.exe on Windows, tool on others.

Perhaps there should be a way to specify -archive-exe-path on per OS/arch basis, or on per URL basis.

Could handle the common case by just special casing and auto adding .exe on Windows though.
@scop scop changed the title Per os/arch or per url exe in archive path Per OS/arch or per URL exe in archive path Nov 15, 2023
@scop
Copy link
Owner Author

scop commented Nov 15, 2023

shellcheck is one example where there's more variance than just .exe vs not; the Windows zip does not have a base dir: https://github.com/koalaman/shellcheck/releases/tag/v0.9.0

scop added a commit that referenced this issue Nov 16, 2023
@scop
feat: per OS/arch archive exe path
0d67e71 
Closes #19
@scop scop mentioned this issue Nov 16, 2023
Merged
@scop scop closed this as completed in #22 Nov 16, 2023
scop added a commit that referenced this issue Nov 16, 2023
@scop
feat: per OS/arch archive exe path
9acdc94 
Closes #19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: per OS/arch archive exe path scop/wrun
1 participant
@scop