Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import latest schema #68

Merged
merged 2 commits into from Dec 14, 2023
Merged

Import latest schema #68

merged 2 commits into from Dec 14, 2023

Conversation

TobiasBabin
Copy link
Contributor

@TobiasBabin TobiasBabin commented Dec 14, 2023

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

The JSON schema displayed on the "Reference / schema reference" page is outdated.

What does this change do?

This change imports the current schema from the score-spec/schema repo. The docs page will automatically display the updated version.

What is your testing strategy?

I used the git subtree pull command as specified in schemas/README.md to pull the latest version.
I compared the JSON files in both repos using diff and found no differences.

Is this related to any issues?

No.

Have you read the Contributing Guidelines?

cff7163 fix: made port required and targetport optional in serviceport definition (#10)
3910c0a fix: added missing protocol field in service ports (#8)
d5df881 fix: converts anonmyous un-named structs into top-level defs (#5)
bcd5a7f fix(schema): move unanchored refs to top level $defs
c83d713 fix(schema): fixed additional properties with invalid regex patterns (#3)
6586e0e feat: support class in resources (#2)

git-subtree-dir: schemas
git-subtree-split: cff7163aa08f928dd49f1f24d14aeb82b537c7ac
Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, yeah the diff looks horrible because we moved a bunch of things into the $defs section to ensure that we can generate intelligable code from the schema. But as long as it's copied directly, that's alright 👍

@TobiasBabin TobiasBabin merged commit 102324b into main Dec 14, 2023
1 check passed
@TobiasBabin TobiasBabin deleted the import-latest-schema branch December 14, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants