Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numbers and bool values with command line overrides #36

Merged
merged 2 commits into from Jun 12, 2023
Merged

Support numbers and bool values with command line overrides #36

merged 2 commits into from Jun 12, 2023

Conversation

ghen
Copy link
Contributor

@ghen ghen commented Jun 8, 2023

Support numbers and bool values with command line overrides.

This change complements #35.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@ghen
Support numbers and bool values with command line overrides
b42ee8c 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
@ghen ghen mentioned this pull request Jun 8, 2023
Merged
7 tasks
@ghen ghen linked an issue Jun 8, 2023 that may be closed by this pull request
Add support for a Score overrides flags score-spec/spec#60
Closed
@ghen
Use yaml package to parse simple values
26bfbab 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
chrishumanitec
chrishumanitec approved these changes Jun 12, 2023
View reviewed changes
Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghen ghen merged commit e3d060f into main Jun 12, 2023
3 checks passed
@ghen ghen deleted the feature/overrides branch June 12, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishumanitec chrishumanitec chrishumanitec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for a Score overrides flags
2 participants
@ghen @chrishumanitec