fix-chart #7
Merged
fix-chart #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
force-pushed
the
main
branch
2 times, most recently
from
d6106a7
to
14c0f91
Compare
astromechza
reviewed
Dec 15, 2023
astromechza
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue with #4, my bad with my local tests.
helm template test workload --repo https://score-spec.github.io/score-helm-chartsorhelm template charts/workloadreturns this error:Fix by safer tests in templating + proposing a smoke test in CI in order to catch such a trivial errors in the future.
Tested:
helm template charts/workload/helm template test charts/workload/ --set workload.annotations.test=testhelm template test charts/workload/ --set service.type=LoadBalancerhelm template test charts/workload/ --set service.type=LoadBalancer --set service.annotations.test=testI also re-packaged the chart with the same version, in order to fix that version out there.