Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed resource properties from score files #20

Merged
merged 5 commits into from
Jul 5, 2023
Merged

removed resource properties from score files #20

merged 5 commits into from
Jul 5, 2023

Conversation

sujaya-sys
Copy link
Contributor

Description

We are planning to deprecate resource properties in the Score spec: score-spec/spec#61

What does this PR do?

It removes resource properties from the example score.yaml files we store in this repo

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

ghen
ghen suggested changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI code needs to be updated. Otherwise these examples won't work and that would confuse the users.

Please wait for code changes before approving/merging these changes.

@rachfop rachfop mentioned this pull request Jun 6, 2023
Merged
1 task
ghen and others added 2 commits June 12, 2023 17:35
@ghen
Deprecate resource properties definitions
aa8eef6 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
@ghen ghen self-requested a review June 15, 2023 14:16
ghen
ghen reviewed Jun 15, 2023
View reviewed changes
Copy link
Contributor

@ghen ghen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Would appreciate someone else to review these changes as well.

chrishumanitec
chrishumanitec requested changes Jul 4, 2023
View reviewed changes
Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typeo otherwise looks good.

internal/helm/convert_test.go Outdated
"user.name": {Required: true, Secret: true},
"password": {Required: true, Secret: true},
},
Type: "posgres",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be postgres missing a t

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ghen
Fixed typo
cd2b5b1 
Signed-off-by: Eugene Yarshevich <yarshevich@gmail.com>
chrishumanitec
chrishumanitec approved these changes Jul 4, 2023
View reviewed changes
Copy link

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghen
Merge branch 'main' into update-examples-helm
1edeaa9 
Signed-off-by: Eugene Y. <ghen@users.noreply.github.com>
@ghen ghen merged commit 1ec922c into main Jul 5, 2023
3 checks passed
@ghen ghen deleted the update-examples-helm branch July 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghen ghen ghen approved these changes

@chrishumanitec chrishumanitec chrishumanitec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sujaya-sys @ghen @chrishumanitec