Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update score-go to 1.1.0 and update go to 1.22 #70

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

astromechza
Copy link
Member

@astromechza astromechza commented Feb 27, 2024

This PR updates score-humanitec to score-go 1.1.0 with the generated types. This is the bulk of the change and causes some things to now be pointers or no longer be pointers. We bump to go 1.22 as well just to keep this up to date (separate dependency updates should be done elsewhere).

Behavior should be much the same as before. Generating the delta from schema/samples/score-full.yaml gives the following:

{
  "id": "<snip>",
  "metadata": {
    "env_id": "development",
    "name": "Auto-deployment (SCORE)",
    "url": "<snip>",
    "created_by": "<snip>",
    "created_at": "2024-02-27T15:53:41.259850885Z",
    "last_modified_at": "2024-02-27T15:53:41.259850885Z"
  },
  "modules": {
    "add": {
      "example-workload-name123": {
        "externals": {
          "resource-one1": {
            "class": "default",
            "params": {
              "extra": {
                "data": "here"
              }
            },
            "type": "Resource-One"
          },
          "resource-two2": {
            "class": "default",
            "type": "Resource-Two"
          }
        },
        "profile": "humanitec/default-module",
        "spec": {
          "annotations": {
            "humanitec.io/managed-by": "score-humanitec"
          },
          "containers": {
            "container-one1": {
              "args": [
                "hello",
                "world"
              ],
              "command": [
                "/bin/sh",
                "-c"
              ],
              "files": {
                "/my/other/file": {
                  "mode": "",
                  "value": "some multiline\ncontent\n"
                }
              },
              "id": "container-one1",
              "image": "localhost:4000/repo/my-image:tag",
              "liveness_probe": {
                "path": "/livez",
                "port": 8080,
                "type": "http"
              },
              "readiness_probe": {
                "headers": {
                  "SOME_HEADER": "some-value-here"
                },
                "path": "/readyz",
                "port": 80,
                "type": "http"
              },
              "resources": {
                "limits": {
                  "cpu": "0.24",
                  "memory": "128M"
                },
                "requests": {
                  "cpu": "1000m",
                  "memory": "10Gi"
                }
              },
              "variables": {
                "SOME_VAR": "some content here"
              },
              "volume_mounts": {
                "/mnt/something": {
                  "id": "volume-name",
                  "read_only": false,
                  "sub_path": "/sub/path"
                },
                "/mnt/something-else": {
                  "id": "volume-two",
                  "read_only": false,
                  "sub_path": ""
                }
              }
            },
            "container-two2": {
              "id": "container-two2",
              "image": "."
            }
          },
          "service": {
            "ports": {
              "port-one": {
                "container_port": 10000,
                "protocol": "TCP",
                "service_port": 1000
              },
              "port-two2": {
                "container_port": 8000,
                "protocol": "TCP",
                "service_port": 8000
              }
            }
          }
        }
      }
    }
  }
}

Signed-off-by: Ben Meier <ben.meier@humanitec.com>
@astromechza astromechza changed the title fix: update score-go to 1.1.0 and update go to 1.21 fix: update score-go to 1.1.0 and update go to 1.22 Feb 27, 2024
@astromechza astromechza marked this pull request as ready for review February 27, 2024 15:57
Copy link
Contributor

@delca85 delca85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astromechza astromechza merged commit 4dffdd2 into main Feb 28, 2024
3 checks passed
@astromechza astromechza deleted the upgrade-spec branch February 28, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants