Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rcField functions private #31

Closed
jacobmerson opened this issue May 5, 2022 · 3 comments
Closed

make rcField functions private #31

jacobmerson opened this issue May 5, 2022 · 3 comments
Assignees

Comments

@jacobmerson
Copy link
Collaborator

working through fixing some rcField tests as I merge sandialabs. I'm wondering if there is any reason why we shouldn't push all of the rcField functions to be private methods on the mesh class? If I understand correctly these functions are all there to have an internal cache of stored values of the reverse classification.

If this is correct, then we should make all those methods private and just have the ask_revClass etc. functions be exposed in the namespace.

@joshia5
Copy link
Collaborator

joshia5 commented May 5, 2022

Changing the functions which need not be exposed in the namespace to private methods sounds reasonable to me. i'll see when i can get to it.

@jacobmerson
Copy link
Collaborator Author

I can make this change when I'm done doing the merge with sandialabs. I will submit a pull request and request your approval to make sure I'm not too zealous with hiding things.

@joshia5
Copy link
Collaborator

joshia5 commented May 5, 2022

sounds good. There is a regression test for rc that runs with the CI workflow which should be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants