Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nents(Topo_type ent_type) doesn't work for mono-topology meshes created with build_box #68

Closed
cwsmith opened this issue Oct 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@cwsmith
Copy link

cwsmith commented Oct 30, 2023

LO Mesh::nents(Topo_type ent_type) const {

Is returning incorrect values for a mesh created with build_box(...). This API was added to support mixed meshes. The original nents(int ent_dim) is compatible with build_box(...).

One option to avoid this is to add a check (compile time?) to see if the mesh is mixed and if not fail in this API.

@cwsmith cwsmith added the bug Something isn't working label Oct 30, 2023
@cwsmith
Copy link
Author

cwsmith commented Mar 6, 2024

Fixed with the refactor of mixed meshes into its own class: #82

@cwsmith cwsmith closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant