[ Fix : Delete Button In Image Drawer ] #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First Need to pull changes from PR #1158, which solves the problem with image upload via
Add ImagesButton. Then, noticed the delete button not working.The
remoteTutorialImagesactions is triggered andcheckUserOrOrgHandle(owner)(firestore)this line was giving the error because it's using two actionscheckUserHandleExistsandcheckOrgHandleExistswhich acceptsfirebaseas params while sendingfirestore, so changed this line accordinglycheckUserOrOrgHandle(owner)(firebase).Related Issue
Fixes #1160
Motivation and Context
The proper use of the delete button.
How Has This Been Tested?
Tested on my machine.
Video:
Codelabz.-.Google.Chrome.2024-02-05.18-14-22.mp4
Types of changes
Checklist: