Profilebanner storybook #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niweera
reviewed
Jul 2, 2022
| @@ -8,7 +8,7 @@ import dp from "../../../assets/images/demoperson1.jpeg"; | |||
| import BannerDemo from "../../../assets/images/OrgBannerDemo.png"; | |||
| import iconbuttonImage from "../../../assets/images/unfilled3holes.svg"; | |||
|
|
|||
| export default function Banner() { | |||
| export default function Banner({ bannerImage, profileImage, name, story, followers, contributors, feed }) { | |||
There was a problem hiding this comment.
did you use prettier in this line?
There was a problem hiding this comment.
I didn't. I have pushed changes after running prettier on all the files related to the pr, in this commit, 43d6a1e
There was a problem hiding this comment.
can you double check, the line is long and it's on a single line which should be broken down to new lines.
There was a problem hiding this comment.
I have made a new commit after running prettier. 43d6a1e
Please check. This line has been broken to multiple short lines.
|
@IITvamp Pls add a gif of the Profilebanner |
Niweera
approved these changes
Jul 2, 2022
Niweera
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
passing value via props to the profile banner components. No changes in the UI in this pr, just changed hardcoded data to props.
Related Issue
#294
Screenshots or GIF (In case of UI changes):
Types of changes
Checklist: