Added select option for storeType in create sensor page #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tharidu
reviewed
Mar 30, 2017
| ng-model="vm.sensor.storeType" | ||
| /> | ||
| <select class="form-control" name="storeType" id="field_storeType" | ||
| ng-model="vm.sensor.storeType" ng-options="storeType as storeType for storeType in vm.storeTypes"> |
There was a problem hiding this comment.
storeType for storeType in vm.storeTypes should work here.
tharidu
reviewed
Mar 30, 2017
| /> | ||
| <select class="form-control" name="storeType" id="field_storeType" | ||
| ng-model="vm.sensor.storeType" ng-options="storeType as storeType for storeType in vm.storeTypes"> | ||
| <option value=""></option > |
There was a problem hiding this comment.
Why do we need a <option> tag here?
There was a problem hiding this comment.
I have removed the tag and added a commit on the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sensor storeType should of type as defined in storeTypes.java. The create sensor page is updated with select option for storeType to avoid errors.