Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset Time #3

Closed
moshed opened this issue Jan 21, 2021 · 6 comments
Closed

Offset Time #3

moshed opened this issue Jan 21, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@moshed
Copy link

moshed commented Jan 21, 2021

hey its me from the other thread. its kind of difficult to test these out as during kodesh times as you cant use the phone. would it be possible to set an offset time so that we can test this out easily

@scorpionmit01
Copy link
Owner

scorpionmit01 commented Jan 21, 2021 via email

@scorpionmit01 scorpionmit01 self-assigned this Jan 21, 2021
@scorpionmit01 scorpionmit01 added the enhancement New feature or request label Jan 21, 2021
@scorpionmit01
Copy link
Owner

Thoughts on implementation, add a field offset, and the time should shift forward/backward by that many minutes?

@moshed
Copy link
Author

moshed commented Jan 21, 2021

yeah! that exactly how I had it in mind.

https://github.com/grover/homebridge-calendar has an offset that is customizable with suffixes for days but the math is easily done for dy to minute conversion so maybe that's overkill.

@scorpionmit01
Copy link
Owner

Implemented in v1.1.0, released tonight.

@scorpionmit01
Copy link
Owner

scorpionmit01 commented Jan 21, 2021 via email

@moshed
Copy link
Author

moshed commented Jan 21, 2021

Wow. Quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants