Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link header with anchor parameter #48

Closed
acoburn opened this issue Apr 9, 2018 · 1 comment
Closed

Link header with anchor parameter #48

acoburn opened this issue Apr 9, 2018 · 1 comment
Labels
Milestone

Comments

@acoburn
Copy link
Contributor

acoburn commented Apr 9, 2018

Environment

Operating system: OS X

Python version: 3.6

LAKEsuperior release, branch, or commit #: 1.0.0alpha12 from pypi

Steps to reproduce

Create an LDP-NR as with #47

Observed behavior

The response includes a response header such as:

Link: <http://localhost:8000/ldp/ee7d7990-24d5-41d3-bc3b-0a59cfd2b739/fcr:metadata>; rel="describedby"; anchor="<http://localhost:8000/ldp/ee7d7990-24d5-41d3-bc3b-0a59cfd2b739>"

Expected behavior

I would not expect to see the anchor parameter to be enclosed in <> characters.

That is, I would expect:

Link: <http://localhost:8000/ldp/ee7d7990-24d5-41d3-bc3b-0a59cfd2b739/fcr:metadata>; rel="describedby"; anchor="http://localhost:8000/ldp/ee7d7990-24d5-41d3-bc3b-0a59cfd2b739"

Other notes worth mentioning

https://tools.ietf.org/html/rfc8288 -- this is the specification for web linking (which defines the anchor param)
The ABNF for the anchor param is "URI Reference", as defined by https://tools.ietf.org/html/rfc3986#section-4.1

@scossu scossu added the bug label Apr 10, 2018
scossu added a commit that referenced this issue Apr 10, 2018
Remove extraneous characters from anchor link. Fixes #48.
@scossu
Copy link
Owner

scossu commented Apr 10, 2018

Fixed in #51

@scossu scossu closed this as completed Apr 10, 2018
@scossu scossu added this to the alpha.13 milestone Apr 13, 2018
@scossu scossu mentioned this issue Apr 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants