Use scoped mocha opts file #29
Conversation
| @@ -76,6 +77,16 @@ From http://benhollis.net/blog/2015/12/20/nodejs-stack-traces-in-emacs-compilati | |||
| (setq i (+ i 1))) | |||
| dir)) | |||
|
|
|||
| (defun mocha-opts-file (mocha-file) | |||
| "Return path to mocha.opts file for MOCHA-FILE." | |||
There was a problem hiding this comment.
This is cool. I actually didn't know mocha supported opts files. I've just been using different .dir-locals files when I need different test configs in the same project.
There was a problem hiding this comment.
Yes and it will always load test/mocha.opts even if not specified.
rejeep
force-pushed
the
use-scoped-mocha-opts-file
branch
from
803edea
to
2797df7
Compare
|
|
||
| ;;;; mocha-generate-command | ||
|
|
||
| (ert-deftest mocha-test/mocha-generate-command/return-command-including-mocha-opts-option () |
There was a problem hiding this comment.
Could you add the negative case to this one for the integration test file? that is has no --opts option?
rejeep
force-pushed
the
use-scoped-mocha-opts-file
branch
2 times, most recently
from
cfcb56c
to
13f7765
Compare
|
The tests fail for me locally with "SyntaxError: Block-scoped declarations (let, const, function, class) not yet supported outside strict mode". Do you know if I have to run it with a specific version of Node? |
|
Node 6 solved it. |
|
Yeah, I just put an .nvmrc with node 6 in the sample project directory. |
|
How do you feel about adding a mocha.opts to the sample project and adding a cuke for this? |
Jupp, will do that! I also found a big with help of your Ecukes-tests that I will fix. |
There may be many different kind of tests with their own mocha.opts file. With this change, if there's a local mocha.opts file, that will be used when running the tests.
rejeep
force-pushed
the
use-scoped-mocha-opts-file
branch
from
13f7765
to
41b8101
Compare
|
I started writing Ecukes tests but soon realised that I don't think we should write many of those. Adding more Node-tests changes the outcome of other features because they run tests for the complete project. Instead I think we should focus on unit tests and only have a few Ecukes tests that make sure all parts run well together. I did some updates to this branch from your feedback, mind taking another look? |
rejeep
force-pushed
the
use-scoped-mocha-opts-file
branch
from
e1870bb
to
41b8101
Compare
|
This LGTM. As fare as cukes go, I think we'll have to make the sample project a little more complex, and maybe have multiple test directories to test different cases like CoffeeScript support. But I'm fine with deferring that till we have more major features to integrate. |
|
Merging this then! 👍 |
|
And I saw you just did! 😄 |
(Note that this branch builds on #27, but is targeted against master, so before looking at this, merge #27)
This change will use any locally scoped
mocha.optsfile. This happens when there are different types of tests (unit, acceptance, integration) with their ownmocha.optsfile.