Hide delete button on non-deleteable statuses

scottbedard · Apr 30, 2017 · 45bb023 · 45bb023
1 parent b3b1f72
commit 45bb023
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 7 deletions.
diff --git a/controllers/statuses/update.htm b/controllers/statuses/update.htm
@@ -33,13 +33,15 @@
                     class="btn btn-default">
                     Save and Close
                 </button>
-                <button
-                    type="button"
-                    class="oc-icon-trash-o btn-icon danger pull-right"
-                    data-request="onDelete"
-                    data-load-indicator="Deleting Status..."
-                    data-request-confirm="Delete this status?">
-                </button>
+                <?php if ($this->vars['formModel']->isDeleteable()): ?>
+                    <button
+                        type="button"
+                        class="oc-icon-trash-o btn-icon danger pull-right"
+                        data-request="onDelete"
+                        data-load-indicator="Deleting Status..."
+                        data-request-confirm="Delete this status?">
+                    </button>
+                <?php endif ?>
                 <span class="btn-text">
                     or <a href="<?= Backend::url('bedard/shop/statuses') ?>">Cancel</a>
                 </span>

diff --git a/models/Status.php b/models/Status.php
@@ -105,6 +105,16 @@ public function beforeSave()
         $this->validateFlags();
     }
 
+    /**
+     * Determine if the status can be deleted.
+     *
+     * @return boolean
+     */
+    public function isDeleteable()
+    {
+        return ! $this->is_default && ! $this->is_abandoned;
+    }
+
     /**
      * Prevent the default status from being removed.
      *

diff --git a/tests/unit/models/StatusTest.php b/tests/unit/models/StatusTest.php
@@ -66,4 +66,15 @@ public function test_the_only_default_status_cannot_be_turned_off()
         $this->setExpectedException(ModelException::class);
         $foo->save();
     }
+
+    public function test_if_statuses_can_be_deleted()
+    {
+        $default = Factory::create(new Status, ['is_default' => 1]);
+        $abandoned = Factory::create(new Status, ['is_abandoned' => 1]);
+        $regular = Factory::create(new Status);
+
+        $this->assertFalse($default->isDeleteable());
+        $this->assertFalse($abandoned->isDeleteable());
+        $this->assertTrue($regular->isDeleteable());
+    }
 }