Add ability to set custom HTML #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. For consistency with the rest of the code can you rework the braces on the if/then on line 155 and the function definition on 226 to be the same brace style as the Once everything is consistent I will gladly land this. Thanks for taking the time. |
Someone on #github suggested that I can send a PR to your branch... I've never done this before, let's see if it works.
|
Someone on #github suggested that I send you a PR on your branch to suggest the style fixes. I clicked the wrong button, and it committed to your repo instead of starting a pull-request. Sorry, I'm new at remote branch stuff. See: dfbaf8e This is now complete, and looks good. I'll merge it! |
|
That's cool, I press the wrong buttons/enter the wrong commands all the time! Glad you were happy with it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With reference to issue #12 , a simple implementation of user-settable custom HTML.
Defaults to using the default WebOTA header, but can be overridden by use of the set_custom_html method.
I kept the changes as simple as possible.