Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client config could be nil if no password/keys are available. Triggers a nil reference. #48

Closed
itzurabhi opened this issue Jun 18, 2019 · 1 comment

Comments

@itzurabhi
Copy link

func genSSHClientConfig(auth *AuthMethod) (*ssh.ClientConfig, error) {

returns a pointer regardless of the 2 if conditions.

return config, nil

should return

config,errors.New("no credentials/keys available")

@scottdware
Copy link
Owner

Thanks for catching this! I'll get this updated!

scottdware added a commit that referenced this issue Jun 18, 2019
scottdware pushed a commit that referenced this issue Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants