Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update p5.sound library #51

Closed
therewasaguy opened this issue Mar 31, 2016 · 2 comments
Closed

update p5.sound library #51

therewasaguy opened this issue Mar 31, 2016 · 2 comments

Comments

@therewasaguy
Copy link
Member

There is a bug with sound on hello.p5js.org right now, as mentioned here and here.

It is fixed in newer versions so the library.

If simply swapping it out for the latest version doesn't work, I can look into it more
@scottgarner
Copy link
Collaborator

Thanks for the head's up, Jason. I'm crunching to deliver a project this week, but will look into this as soon as I get a chance.

scottgarner added a commit that referenced this issue Apr 7, 2016
@scottgarner
Libray updates and API chnage fixes for #51.
a5b394b
@scottgarner
Copy link
Collaborator

I updated to the latest p5 and p5.sound. There had been a lot of API changes since the site launched—hopefully I made the right fixes.

Things seem to work, though I did notice an error onsketch.remove(); in Chrome:

p5.sound.min.js:4 Uncaught TypeError: Cannot read property 'disconnect' of undefined

scottgarner added a commit that referenced this issue Apr 7, 2016
@scottgarner
Minified addons for #51.
8587a5a
@therewasaguy therewasaguy mentioned this issue Apr 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@therewasaguy @scottgarner