Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api calls not supporting promises. #3

Closed
singerxt opened this issue Jun 7, 2016 · 2 comments
Closed

Api calls not supporting promises. #3

singerxt opened this issue Jun 7, 2016 · 2 comments

Comments

@singerxt
Copy link

singerxt commented Jun 7, 2016

Hey! Thanks for all your hard work on writing Gigya wrapper for node.js ! :-)

I think will be good to support promises for example

gigya.socialize.getToken(params)
  .then(loginUser)
  .catch(errorHandler)
@scotthovestadt
Copy link
Owner

Yeah, I agree. I'd actually like to refactor this as a breaking change to be promises-only.

For now, you can use bluebird promisify to automatically convert to promises.

@scotthovestadt
Copy link
Owner

@singerxt 6 months later - I just released a new version that supports promises. It also has support for TypeScript definitions! (If you haven't tried TS, I recommend it. A lot.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants