Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If you're going to make backwards-compatible breaking changes to your API, you need to increment more than the patch version #46

Closed
EdwardDrapkin opened this issue Dec 14, 2017 · 5 comments

Comments

@EdwardDrapkin
Copy link
Contributor

My builds broke because you do not follow semver.

Please follow semver.

Another breakage and I will drop your package and use something else. It's not a hard standard to follow and wasting a bunch of others' time because you're too lazy is really rude.

@EdwardDrapkin EdwardDrapkin changed the title If you're going to make backwards-compatible breaking changes to your API, you need to increment more than t he patch version If you're going to make backwards-compatible breaking changes to your API, you need to increment more than the patch version Dec 14, 2017
@scottie1984
Copy link
Owner

Can you explain the issue? It was not meant to be a breaking change, apologies for the time wasted.

@EdwardDrapkin
Copy link
Contributor Author

EdwardDrapkin commented Dec 14, 2017

The only thing I did was try to create a new yarn.lock file and wound up with this stack trace:

 stack:
   [ 'TypeError: Cannot read property \'explorer\' of null',
     '    at Object.setup (/Users/edwarddrapkin/projects/kraken-event-scheduler/node_modules/swagger-ui-express/index.js:13:23)',

Downgrading to the release from yesterday(?) fixed it.

Here's the call site:

    app.use('/documentation',
        swaggerUi.serve,
        swaggerUi.setup(null, null, null, customCSS, null, '/documentation.json', 'Event Scheduler documentation')
    );

@scottie1984
Copy link
Owner

Apologies, i will fix this now!

@EdwardDrapkin
Copy link
Contributor Author

Thanks, sorry for venting, it was extremely frustrating to have a build break at deployment and have no idea why and it took a while to figure it out.

@scottie1984
Copy link
Owner

No problem - I have fixed the issue now. Any problems let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants