Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

Safari 5 Bug #48

Closed
luksak opened this issue Nov 19, 2012 · 6 comments
Closed

Safari 5 Bug #48

luksak opened this issue Nov 19, 2012 · 6 comments

Comments

@luksak
Copy link

luksak commented Nov 19, 2012

I had the issue that on AJAX loaded content where I re-apply the picturefill, Safari 5.0.5 did confuse the img tag in the noscript tag with a already replace image. I made a commit where I fixed this:

luksak@0b82846

@attiks
Copy link
Contributor

attiks commented Nov 23, 2012

This sound like a Safari bug, when javascript is active, it shouldn't check inside the noscript tag

@luksak
Copy link
Author

luksak commented Nov 23, 2012

True. Shouldn't we try to fix it?

@attiks
Copy link
Contributor

attiks commented Nov 23, 2012

I think it should be filed as a bug against safari

@luksak
Copy link
Author

luksak commented Nov 23, 2012

Yeah, it has already been fixed. Do you want to ignore this?

@attiks
Copy link
Contributor

attiks commented Nov 23, 2012

As said before, I got multiple images using that fix, please create a patch against the picturefill we're using right now, so I can test this a bit easier, and file a bug against picture in Drupal, if it works we can make a PR upstream.

@scottjehl
Copy link
Owner

We're closing this out as Picturefill gets refactored to support the new standard markup landing in browsers. Thread here: #125

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants