Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for escape sequences #26

Merged
merged 6 commits into from
Nov 14, 2018
Merged

Conversation

Roslund
Copy link
Contributor

@Roslund Roslund commented Jun 19, 2018

This should resolve #5. I have changed the stripping pattern to account for additional escape sequence. However, I am not aware of all escape sequences, so I might have missed something.

All test passes and I have tested it with the example provided by @kiliankoe in the issue thread.
I have also added two additional stripping test that fail on master.

I would advise some testing before merging.

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@80a5310). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #26   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      2           
  Lines             ?    257           
  Branches          ?      0           
=======================================
  Hits              ?    257           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
Source/SwiftyTextTable/TextTable.swift 100% <100%> (ø)
...ts/SwiftyTextTableTests/SwiftyTextTableTests.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a5310...306b210. Read the comment docs.

@eneko
Copy link
Contributor

eneko commented Sep 4, 2018

Any updates on this?

@eneko
Copy link
Contributor

eneko commented Nov 14, 2018

@jpsim could you please take a look at this one? I'm personally using it on some CLI tools and works pretty well with Rainbow.

@jpsim
Copy link
Collaborator

jpsim commented Nov 14, 2018

LGTM, thanks!

@jpsim jpsim merged commit c96adf2 into scottrhoyt:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve support for escape sequences to support Rainbow.
3 participants