Add embedded test and small optimization

scottwrobinson · Jun 24, 2016 · 2ec0e9e · 2ec0e9e
1 parent 0f89492
commit 2ec0e9e
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 3 deletions.
diff --git a/lib/base-document.js b/lib/base-document.js
@@ -480,10 +480,10 @@ class BaseDocument {
                 }
             }
         }
-        var proto = Object.getPrototypeOf(this);
-        var protoProps = Object.getOwnPropertyNames(proto);
-
         if (this._extractDocPropertiesOnly !== true) {
+            var proto = Object.getPrototypeOf(this);
+            var protoProps = Object.getOwnPropertyNames(proto);
+
             for (var i = 0; i < protoProps.length; i++) {
                 key = protoProps[i];
                 if (key !== 'constructor' && key !== 'id') {

diff --git a/test/embedded.test.js b/test/embedded.test.js
@@ -669,5 +669,49 @@ describe('Embedded', function() {
                 expect(json.address.isPoBox).to.be.equal(false);
             }).then(done, done);
         });
+
+        it('should serialize data to JSON and ignore methods recursively if configured', function(done) {
+            class Address extends EmbeddedDocument {
+                constructor() {
+                    super();
+                    this.street = String;
+                }
+
+                getBar() {
+                    return 'bar';
+                }
+            }
+
+            class Person extends Document {
+                constructor() {
+                    super();
+
+                    this.name = String;
+                    this.address = Address;
+                    this._extractDocPropertiesOnly = true;
+                }
+
+                static collectionName() {
+                    return 'people';
+                }
+
+                getFoo() {
+                    return 'foo';
+                }
+            }
+
+            var person = Person.create({
+                name: 'Scott',
+                address : {
+                    street : 'Bar street'
+                }
+            });
+
+            var json = person.toJSON();
+            expect(json).to.have.keys(['_id', 'name', 'address']);
+            expect(json.address).to.have.keys(['street']);
+
+            done();
+        });
     });
 });