Added a required key value validation. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated README.md file. - Written tests for required validation. - Validation doesn't allow empty string, empty array or empty object. It does allow '0' number value.
|
Thanks for the PR! From what I can tell it looks good. I'll merge it with some other updates I've done later this week. Scott |
|
Thanks Scott! I am happy to hear that. Let me know if you find that I've missed something. Kind Regards, |
scottwrobinson
added a commit
that referenced
this pull request
Dec 15, 2015
Conflicts: test/document.test.js Merged PR #19
scottwrobinson
added a commit
that referenced
this pull request
Dec 15, 2015
scottwrobinson
added a commit
that referenced
this pull request
Dec 15, 2015
bvkimball
pushed a commit
to bvkimball/crypsis
that referenced
this pull request
Jan 15, 2016
* upstream/master: (41 commits) Bumped version, updated CHANGELOG, and updated README Fixed serialization test for MongoDB IDs Deprecated 'id' alias on document object for issue scottwrobinson#20 Removing some inconsistencies with accessing the ID. Partially covers issue scottwrobinson#20 Consolidated hook code so it can be re-used throughout Document methods Moved collectionName method to BaseDocument. Fixes scottwrobinson#26 Added new ValidationError object, fixed some validation tests, fixed min/max validation, and fixed validation for array of embedded documents Fixed issue with running 'canonicalize' tests on travis-ci and bumped version Removed unused harmony-reflect dependency, updated CHANGELOG, and bumped version Updated CHANGELOG, README, and bumped version Removed --harmony-proxies flag from tests now that Proxy isn't used Added sanity check to 'required' tests Updated PR scottwrobinson#19 to conform to new collection naming Changed how you name collections Removed need for Proxy and harmony-reflect dependency Added a required key value validation. Adding .npmignore file Moved jshint settings out of package.json and in to .jshintrc file. Updated .gitignore for .jshintrc Removed custom harmony-reflect script and adding harmony-reflect as dependency Added tests for canonicalizing dates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18