Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root detection failed on Motorolla Device Model XT1706 #39

Closed
bytekode opened this issue Mar 23, 2017 · 5 comments
Closed

Root detection failed on Motorolla Device Model XT1706 #39

bytekode opened this issue Mar 23, 2017 · 5 comments

Comments

@bytekode
Copy link

According to the same app provided on Google play store, it shows the device has busy box binary installed and all other checks are negative.
The sample didn't detected su binary and su management apps but still flag my device as rooted. How is that possible?

Feel free if any other details or logs are required.

Here is the device model I am referring to
http://www.gsmarena.com/motorola_moto_e3_power-8337.php

@stealthcopter
Copy link
Collaborator

Sorry can I just confirm your situation.
Are you saying the Moto E3 has a busy box binary present? or that you have rooted your device and the sample fails to find any root management apps?

It would be useful if you could provide the logcat output when running the sample, thanks.

@bytekode
Copy link
Author

bytekode commented Mar 24, 2017

@stealthcopter So my Moto E3 was not rooted and according to the sample app from Play Store it states that busy box binary was present on Moto E3.

I'll give you logs some time later Today. Attaching screen shot from Moto E3 here.
moto e

@stealthcopter
Copy link
Collaborator

It looks like some manufactures decide forget to remove the busybox binary from the system, or perhaps it is a conscious decision to do so for some unknown reason. Whilst this can be an annoyance creating a false positive for suggesting a device is rooted, it is still a sign of rooting nonetheless. If you want to avoid this problem in your own use of the library, you can simply remove the call to checkForBusyBoxBinary().

I will suggest adding this to the readme so that this has more visiblity.

@bytekode
Copy link
Author

Attached is the logs from Redmi note 3 and rootbeer is detecting busybox binary in case of Moto E3, Xiaomi Redmi Note 3 and One plus one. I think most of the manufacturers are adding busybox binary. Any thoughts?

redmi_note_3_logs.txt

@stealthcopter
Copy link
Collaborator

@bytekode As of commit 91e0a11 we've added a new method for the library to have a new method rootBeer.isRootedWithoutBusyBoxCheck(), so that you can avoid false positives inside your application when using the library.

As for the sample app it makes sense to keep it as is, as this is merely an indication of root and states so at the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants