Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xvfb / notty support #62

Merged
merged 2 commits into from
May 14, 2020
Merged

Conversation

runzhammer
Copy link

Sometimes I just have to run some old windows stuff with no active display.
So I added xvfb, set DISPLAY to the xvfb display and send all screen stuff into the void :)
Small change which made this project useful for me.
Cheers!

@scottyhardy
Copy link
Owner

Hi @runzhammer

That's brilliant! Love your work 👍
I'd thought of adding xvfb as a handy way of managing configs and performing installs for downstream Dockerfiles or scripts but hadn't bothered yet. I'm happy to hear that docker-wine has been useful and very happy to include your improvements 😄

@scottyhardy scottyhardy merged commit d28b3cf into scottyhardy:master May 14, 2020
@scottyhardy
Copy link
Owner

Unfortunately you're not showing up in the list of contributors... maybe because the username you committed your changes with didn't match your GitHub username?

Anyways, thanks again and I'll make sure to mention your contribution for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants