fix: Fix faulty empty array check in pre-commit #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When no shell scripts were changed the empty array was checked using a defrefrence of an unset variable, causing an error. Use arithmetic an expression to test the count in the array. * Remove trailing slash on `hooksPath` to prevent double slash in printing errors and keeping with git conventions
scottyhardy
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whoops, forgot to test if no changed shelll scripts in stage
defrefrence of an unset variable, causing an error. Use arithmetic an
expression to test the count in the array.
hooksPathto prevent double slash inprinting errors and keeping with git conventions:
https://git-scm.com/docs/git-config#Documentation/git-config.txt-corehooksPath